Merged
Conversation
Owner
|
Thank you for pushing this forward. I will comment on the original issue how to proceed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependencies to a current version.
I've also created a updated fork of tonic with the client feature: https://github.com/lucasmerlin/tonic/tree/wasm-client-feature
Unfortunately I've had to enable tokio_unstable to get the wasm version to compile, not really sure why.
If you want you could use my changes in the tonic fork to update your PR hyperium/tonic#693 or alternatively I could open an new one with my updated changes.
I've tried my updated changes in the project I'm working on and everything is working flawlessly! All problems I had with grpc_web are now gone. Thanks for your work on this!